Jim Tcl
Check-in [6220fc5fc0]
Not logged in

Many hyperlinks are disabled.
Use anonymous login to enable hyperlinks.

Overview
Comment:remove some unused variable assignments

Signed-off-by: Steve Bennett <steveb@workware.net.au>

Timelines: family | ancestors | descendants | both | trunk
Files: files | file ages | folders
SHA1: 6220fc5fc08a6f45ad7d5d3c0f3a394db1c49612
User & Date: steveb@workware.net.au 2018-07-08 11:47:53
Context
2018-07-08
11:48
exec: Better adhere to possible vfork restrictions

Avoid modification of any variables on the parents stack. Avoid use of stdio in the event that execve fails.

Signed-off-by: Steve Bennett <steveb@workware.net.au> check-in: fc4c80e31e user: steveb@workware.net.au tags: trunk

11:47
remove some unused variable assignments

Signed-off-by: Steve Bennett <steveb@workware.net.au> check-in: 6220fc5fc0 user: steveb@workware.net.au tags: trunk

01:49
build-jim-ext: Improvements when cross compiling, Tcl

Detect when cross compiling (build != host) Tcl exec loses stderr if redirected and an error code is returned, so redo the approach to exec so that it works on both Tcl and Jim

Signed-off-by: Steve Bennett <steveb@workware.net.au> check-in: 7c5bcde648 user: steveb@workware.net.au tags: trunk

Changes
Hide Diffs Unified Diffs Ignore Whitespace Patch

Changes to jim-exec.c.

1094
1095
1096
1097
1098
1099
1100
1101
1102
1103
1104
1105
1106
1107
1108
         */

        if (inputId != -1) {
            close(inputId);
        }
        if (outputId != -1) {
            close(outputId);
            outputId = -1;
        }
        inputId = pipeIds[0];
        pipeIds[0] = pipeIds[1] = -1;
    }
    *pidArrayPtr = pidPtr;

    /*







<







1094
1095
1096
1097
1098
1099
1100

1101
1102
1103
1104
1105
1106
1107
         */

        if (inputId != -1) {
            close(inputId);
        }
        if (outputId != -1) {
            close(outputId);

        }
        inputId = pipeIds[0];
        pipeIds[0] = pipeIds[1] = -1;
    }
    *pidArrayPtr = pidPtr;

    /*

Changes to jim-interactive.c.

85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
#ifdef HAVE_UMASK
    mode_t mask;
    /* Just u=rw, but note that this is only effective for newly created files */
    mask = umask(S_IXUSR | S_IRWXG | S_IRWXO);
#endif
    linenoiseHistorySave(filename);
#ifdef HAVE_UMASK
    mask = umask(mask);
#endif
#endif
}

void Jim_HistoryShow(void)
{
#ifdef USE_LINENOISE







|







85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
#ifdef HAVE_UMASK
    mode_t mask;
    /* Just u=rw, but note that this is only effective for newly created files */
    mask = umask(S_IXUSR | S_IRWXG | S_IRWXO);
#endif
    linenoiseHistorySave(filename);
#ifdef HAVE_UMASK
    umask(mask);
#endif
#endif
}

void Jim_HistoryShow(void)
{
#ifdef USE_LINENOISE